Update README.md #51
Merged
Update README.md #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seh
suggested changes
Sep 22, 2016
| @@ -11,16 +11,20 @@ c.GetApps() // returns a map[String]fargo.Application | |||
| # Testing | |||
|
|
|||
| Tests can be executed using docker container. See the below section to build and start | |||
| all the required containers. Once fargo container is running: | |||
| all the required containers. Once eureka containers are running, and fargo container is built. | |||
There was a problem hiding this comment.
- Capitalize "Eureka" as a proper noun.
- s/Once Eureka/Once the Eureka/
- s/container is built./image is built,/
For the last one, did you mean to say that once the containers are running and the fargo image is built, then you can run the command that follows?
| ``` | ||
| docker run --rm -v "$PWD":/go/src/github.com/hudl/fargo -w /go/src/github.com/hudl/fargo hudloss/fargo:master go test -v ./... | ||
| ``` | ||
| Note: If you are running bash for windows add `MSYS_NO_PATHCONV=1 ` at the beggining |
There was a problem hiding this comment.
- Capitalize "Windows" as a proper noun.
- s/beggining/beginning./
|
|
||
| The tests may need to be run a couple of times to allow changes to propagate | ||
| between the two eureka servers. If the tests are failing, try running them again | ||
| approximately 30 seconds later. | ||
|
|
||
| If you are adding new packages to godep you may want to update hudloss/fargo image first. |
There was a problem hiding this comment.
- s/update hudloss/update the hudloss/
There was a problem hiding this comment.
Thanks, all updated.
Typos fixing
seh
approved these changes
Sep 22, 2016
|
Well docker and testing is working. Right now we have a bigger problem - tests are failing on master. I'm trying to figure out why, but since I'm not very familiar with whole code it might take a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new - easier way of running tests for fargo.