fix: move the vertices/edges selected polling methods into the invoke…

… method for the edge_bevel, vertex_bevel, and clear_vgs operators to avoid freeing any existing object's BMesh instance
hugemenace · Nov 19, 2024 · 7ae5a2b · 7ae5a2b
1 parent 179ab7a
commit 7ae5a2b
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/bevels/edge_bevel.py b/bevels/edge_bevel.py
@@ -171,6 +171,9 @@ def do_modal(self, context, event):
     def do_invoke(self, context, event):
         if context.active_object is None:
             self.report({'ERROR_INVALID_INPUT'}, "No active target object selected.")
+
+        if not obj_edges_selected(context.active_object):
+            self.report({'INFO'}, "No edges selected.")
             return {'CANCELLED'}
 
         if event.ctrl:
@@ -242,7 +245,7 @@ def do_invoke(self, context, event):
     @classmethod
     def poll(cls, context):
         target_object = context.active_object
-        return ctx_edit_mode(context) and obj_is_mesh(target_object) and obj_edges_selected(target_object)
+        return ctx_edit_mode(context) and obj_is_mesh(target_object)
 
 
     def prepare_new_operator(self, context):

diff --git a/bevels/vertex_bevel.py b/bevels/vertex_bevel.py
@@ -142,6 +142,9 @@ def do_modal(self, context, event):
     def do_invoke(self, context, event):
         if context.active_object is None:
             self.report({'ERROR_INVALID_INPUT'}, "No active target object selected.")
+
+        if not obj_verts_selected(context.active_object):
+            self.report({'INFO'}, "No vertices selected.")
             return {'CANCELLED'}
 
         if event.ctrl:
@@ -232,7 +235,7 @@ def do_invoke(self, context, event):
     @classmethod
     def poll(cls, context):
         target_object = context.active_object
-        return ctx_edit_mode(context) and obj_is_mesh(target_object) and obj_verts_selected(target_object)
+        return ctx_edit_mode(context) and obj_is_mesh(target_object)
 
 
     def summon_old_operator(self, context):

diff --git a/sketch/clear_vgs.py b/sketch/clear_vgs.py
@@ -40,12 +40,15 @@ class ND_OT_clear_vgs(bpy.types.Operator):
     @classmethod
     def poll(cls, context):
         target_object = context.active_object
-        return ctx_edit_mode(context) and obj_exists(target_object) and obj_verts_selected(target_object)
+        return ctx_edit_mode(context) and obj_exists(target_object)
 
 
     def execute(self, context):
         if context.active_object is None:
             self.report({'ERROR_INVALID_INPUT'}, "No active target object selected.")
+
+        if not obj_verts_selected(context.active_object):
+            self.report({'INFO'}, "No vertices selected.")
             return {'CANCELLED'}
 
         bm = bmesh.from_edit_mesh(context.active_object.data)