add models support and example for THUDM/glm-4 #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't seem to compile, see the CI issues. |
|
CI still seems to be broken, please ensure that rustfmt and clippy are properly run. |
| let inv_freq = Tensor::from_vec(inv_freq, (1, inv_freq_len), dev)?.to_dtype(dtype)?; | ||
| let t = Tensor::arange(0u32, cfg.seq_length as u32, dev)? | ||
| .to_dtype(dtype) | ||
| .expect("unalbe to dytpe in Rotray Embedding new") |
There was a problem hiding this comment.
Avoid using expect and return a proper error instead using ?.
LaurentMazare
approved these changes
Aug 5, 2024
|
Thanks. |
EricLBuehler
pushed a commit
to EricLBuehler/candle
that referenced
this pull request
Aug 14, 2024
* add models support and example for THUDM/glm-4 * fix the ci report * fmt * fix * Update README.org * Update README.org * fmt * Update README.org * README.md add codegeex4 * README.md add glm4 * Typo. * change expect into ? --------- Co-authored-by: Laurent Mazare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.