fix: 🐛 don't mark empty splits as stalled #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
severo
force-pushed
the
fix-empty-split-marked-as-stalled
branch
from
5273a8a to
369b685
Compare
no need to create a release for that. BREAKING CHANGE: 🧨 is_dataset_in_queue and is_split_in_queue are removed
and also simplify the logic: don't look at the queue, it's not the business of the user
the errors now have a MAX_AGE_SHORT_SECONDS cache duration, and we set it to 2s for the tests. This way, we can do real e2e tests through the nginx proxy, and still have quick results.
the test works locally, but not on the CI
|
^ it's weird: I added a test, and now the other failing tests are working. Possibly we have to improve the control of the startup with docker compose: https://docs.docker.com/compose/startup-order/. And we should not start the tests before all the infrastructure is ready (db, API, workers) |
now that the response time of all the endpoints is low, and while the traffic is low, I think it's better to have a simpler logic in the nginx cache: never use stale cache entries, always ask the api for the response if not in the cache.
also: reduce the cache time under the duration of the tests
severo
changed the title
severo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix #185 and #177