-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /first-rows endpoint #431
Conversation
It is a lot simpler in the sense that we simply store HTTP responses, with a lot less logic than in cache.
Also: fix an issue to ensure the datetime always carry the timezone
The documentation is not available anymore as the PR was closed or merged. |
using the new version of libcache and libqueue
also make the logs format a bit more coherent
comparing to 2.3.2, it provides: a) timestamp cast to datetime, b) features with inference in streaming mode: IterableDataset._resolve_features()
thanks to _resolve_features(). Props to @lhoestq
/split-next will replace /splits (new implementation) while /first-rows will replace /rows (new implementation and new route)
also add e2e test for these two endpoints
The goal is to pass full URL in /first-rows (ie: https://datasets-server.huggingface.co/assets/common_voice/--/tr/train/0/audio/audio.mp3) instead of relative URL as in /rows (ie: assets/common_voice/--/tr/train/0/audio/audio.mp3)
to ensure the app is ready
I deployed it on the ephemeral cluster:
Then, once the pods have been initiated, I ensured the reverse-proxy and the API is responsive
Then I launched a webhook for the dataset https://huggingface.co/datasets/wikimedia/wit_base:
After some time, the new
And also the new It has the Also: note that the image URL are no more relative but full, eg https://datasets-server.us.dev.moon.huggingface.tech/assets/wikimedia/wit_base/--/wikimedia--wit_base/train/0/image/image.jpg that resolves to the image on the same API: The former endpoints, still working for backwards compatibility: |
This PR is too awfully big to ask for a review, so I'm merging (the CI is green, and my manual tests on ephemeral are OK) |
No description provided.