Stop the count

[lhoestq]

fix #480

[HuggingFaceDocBuilderDev]

The documentation is not available anymore as the PR was closed or merged.

[severo]

Thanks!

I already set an environment variable for datasets in the worker, see here:

https://github.com/huggingface/datasets-server/blob/519cf70758e34e54f0647560f36dc1f2ac395720/services/worker/src/worker/config.py#L52-L53

I think it would be better to set HF_UPDATE_DOWNLOAD_COUNTS there too, for consistency.

[severo]

I think it's OK to hardcode it to false (the alternative would be to pass an env var to the image, but I don't think we will ever want to set it to true)

[lhoestq]

Ok, I just moved the change to config.py :)

[severo]

Excellent, thanks!

[severo]

Beware, before merging, we have to update the docker image tag in https://github.com/huggingface/datasets-server/blob/main/chart/docker-images.yaml (with 3dc7f29, the last commit, once the build-and-push-image job has succeeded). And let the CI work on the new docker tag

[severo]

e2e error, but it's a known issue, we need to fix #367. We can merge

[severo]

🎉