Add error code #482
Merged
Add error code #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
a Status400Error must be created when we create HTTP responses. Deeper in the code, we don't know if it will be used for this or not.
in the response
also: fix imports, and tests
I think it's the best status code when the datasets library raises.
the arguments were given in the wrong order
and also: use connect_to_cache from simple_cache instead of cache which will be deprecated
also add e2e tests based on the openapi spec (contract testing). Hopefully this commit fixes #367 Note that more examples should be added to the openapi spec, and tested in e2e tests
also: wait for the reverse proxy, the api and the admin apps to be up.
TEST_TARGET=tests/one_file.py make test-target TEST_TARGET=tests/one_file.py TEST_EXPRESSION=test_this_dataset_fn make test-target-expression
This was referenced Jul 28, 2022
to match the examples in openapi.json
because the e2e tests rely on it (contract testing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.