-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use hub ci for tests #499
Merged
Merged
Use hub ci for tests #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation is not available anymore as the PR was closed or merged. |
instead of relying on huggingface_hub and having to HF_ENDPOINT to it, we just rely on datasets, which raises an exception in that case (we have to rely on the error message, which is not very good). Also: disable tests for the moment, because the datasets have been deleted.
also: update huggingface-hub
for that we have to use huggingface_hub. We pass HF_ENDPOINT.
And remove EXTERNAL_AUTH_URL, to replace it with HF_AUTH_PATH, a relative path to HF_ENDPOINT.
Using the path from the hub: "/api/datasets/%s/auth-check"
All the datasets are created on the fly (then delete afterward) on https://hub-ci.huggingface.co. No more tests against the prod Hub. A lot of tests have been disabled and should be created again as fixtures.
also add tests for /splits and /rows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.