feat: 🎸 return 404 for /healthcheck and /metrics #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(and under /admin too). Fixes #540.
severo
added a commit
that referenced
this pull request
Mar 2, 2023
It's not really a security issue to publish them, I think (it was the reason why we protected them along with /metrics in #541). The /healthcheck endpoint is needed for ArgoCD
severo
added a commit
that referenced
this pull request
Mar 2, 2023
* refactor: 💡 simplify the code * fix: 🐛 publish /healthcheck and /admin/healthcheck endpoints It's not really a security issue to publish them, I think (it was the reason why we protected them along with /metrics in #541). The /healthcheck endpoint is needed for ArgoCD * style: 💄 remove unused imports * test: 💍 fix e2e tests
mattstern31
added a commit
to mattstern31/datasets-server-storage-admin
that referenced
this pull request
Nov 11, 2023
* refactor: 💡 simplify the code * fix: 🐛 publish /healthcheck and /admin/healthcheck endpoints It's not really a security issue to publish them, I think (it was the reason why we protected them along with /metrics in huggingface/dataset-viewer#541). The /healthcheck endpoint is needed for ArgoCD * style: 💄 remove unused imports * test: 💍 fix e2e tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(and under /admin too). Fixes #540.