Fix private to public #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now use the webhook only to get the name of the dataset to handle. Then, if the dataset is supported (exists, is public, can be gated or not), update the cache; otherwise, delete the cache.
When a request comes to splits/, if no cache entry exist for the dataset, and if no job is pending either, we now check on the Hub if the dataset exists and is supported (ie. not private). If so, it means that we somehow missed a webhook. We add a job to the queue, and we respond with a "NotReady" error. Otherwise, we respond with "NotFound". This change is a quick fix for #380 (comment) Also: to be able to test, we changed the test library "responses" to a proper HTTP server ("pytest-httpserver" library), which gives us more flexibility to mock the Hub APIs (both the auth endpoint and the API datasets endpoint) and test even if we use huggingface_hub lib in the code. Also: the tests are a bit more precise (more cases)
also: dataset_name -> dataset. also: fix style
If a request is made to /first-rows and there is no entry in the cache, we check if it should. Various cases have to be managed, which makes the logic a bit (too) convoluted. We return a FirstRowsNotReady error if: - the /first-rows response for the split is already in process - the /splits response for the dataset is still in process We return a FirstRowsNotReady error, AND we add a /splits job because something has failed before, if: - the /splits response for the dataset exists, and the split is part of the splits of the dataset - the /splits response for the dataset does not exist, is not in process, but it should because the dataset is supported. Note that I didn't add a unit test for every of these cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #380 (comment):
and
https://github.com/huggingface/moon-landing/issues/2362#issuecomment-1254774183
In this PR, if a response to /splits or /first-rows is NotFound but should have existed, ie. is a cache miss, we add a job to the queue, and return a NotReady error instead.