Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify docker #654

Merged
merged 3 commits into from
Nov 29, 2022
Merged

Simplify docker #654

merged 3 commits into from
Nov 29, 2022

Conversation

severo
Copy link
Collaborator

@severo severo commented Nov 29, 2022

No description provided.

and factorize common code in templates
and simplify the code. Also: fix the names of some env vars: QUEUE_...
-> WORKER_...
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Base: 84.45% // Head: 85.56% // Increases project coverage by +1.10% 🎉

Coverage data is based on head (9088319) compared to base (b5b820a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
+ Coverage   84.45%   85.56%   +1.10%     
==========================================
  Files          10       54      +44     
  Lines         283     2597    +2314     
==========================================
+ Hits          239     2222    +1983     
- Misses         44      375     +331     
Flag Coverage Δ
jobs_mongodb_migration 83.92% <ø> (?)
libs_libcommon 85.22% <ø> (?)
services_admin 84.45% <ø> (ø)
services_api 85.94% <ø> (?)
workers_first_rows 85.71% <ø> (?)
workers_splits 97.91% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
services/api/src/api/routes/valid.py 88.37% <0.00%> (ø)
services/api/src/api/routes/webhook.py 66.12% <0.00%> (ø)
libs/libcommon/src/libcommon/simple_cache.py 100.00% <0.00%> (ø)
.../migrations/_20221116133500_queue_job_add_force.py 74.54% <0.00%> (ø)
libs/libcommon/tests/test_dataset.py 100.00% <0.00%> (ø)
...ngodb_migration/src/mongodb_migration/migration.py 86.95% <0.00%> (ø)
workers/first_rows/src/first_rows/config.py 100.00% <0.00%> (ø)
workers/first_rows/tests/test_features.py 100.00% <0.00%> (ø)
libs/libcommon/tests/test_config.py 100.00% <0.00%> (ø)
libs/libcommon/src/libcommon/log.py 100.00% <0.00%> (ø)
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

and remove unused global makefile targets.
@severo severo merged commit 4ab24c5 into main Nov 29, 2022
@severo severo deleted the simplify-docker branch November 29, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants