Create children in generic worker #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 89.87% // Head: 88.44% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #677 +/- ##
==========================================
- Coverage 89.87% 88.44% -1.43%
==========================================
Files 17 19 +2
Lines 563 1333 +770
==========================================
+ Hits 506 1179 +673
- Misses 57 154 +97
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I searched the other apps code; it seems that datasets-server is the only app to use this token in the CI. So: no other impacted apps. |
it reads the remote parquet files (from the Hub) with hffs and pyarrow.
using libcommon 0.6.2, we implement get_new_splits to be able to create the children jobs. Also: ensure the type of the config and split (str) in /splits
severo
force-pushed
the
create-children-in-generic-worker
branch
from
5c962d4 to
d7afa59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting (from #670) the logic to create the children jobs