-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: 🎡 build the images before running the e2e tests #716
Conversation
See #712 (comment). It removes the need to edit the chart/docker-images.yaml file.
because it seems that the images are build without getting access to the cache from the docker hub.
This reverts commit c57e428.
In the e2e action, I call I'm using The remote cache is the image with the The last merge to the main branch has generally created this cache through the action that builds and pushes the docker images: We can see in the logs that the cache has been requested and read without an error: But still: it seems not to be used at all, and all the layers are built again. For example, step 2 (apt install) is run again: What can be the reason? |
thanks @XciD. Hopefully it will work...
the import did not work: https://github.com/huggingface/datasets-server/actions/runs/4026723336/jobs/6921581199#step:4:114. Alternative would be to change the working directory, but I realized we don't need two files anymore.
This reverts commit da89e71.
I don't understand why the cache (gha) is not used when we use several images. It worked when we only built one image (admin). I guess that the cache size (10GB) has been reached, leading to the images being deleted one after the other. So:
Maybe the only solution, for now, is to build without a cache at all. The action takes 16 minutes (see https://github.com/huggingface/datasets-server/actions/runs/4025495859/jobs/6918785905) |
Merge as is: it only makes the e2e tests build the images every time, without using a cache. Part of #712. |
See
#712 (comment). It removes the need to edit the chart/docker-images.yaml file.