Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: 🎡 only run on PR and on main #758

Merged
merged 1 commit into from
Feb 2, 2023
Merged

ci: 🎡 only run on PR and on main #758

merged 1 commit into from
Feb 2, 2023

Conversation

severo
Copy link
Collaborator

@severo severo commented Feb 1, 2023

currently, the actions are run twice in the PRs. See c80eeac for example.

currently, the actions are run twice in the PRs. See
c80eeac
for example.
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2023

Codecov Report

Base: 90.14% // Head: 90.08% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (2f23d4c) compared to base (7cc7367).
Patch coverage: 18.91% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
- Coverage   90.14%   90.08%   -0.06%     
==========================================
  Files          99       99              
  Lines        5051     4944     -107     
==========================================
- Hits         4553     4454      -99     
+ Misses        498      490       -8     
Flag Coverage Δ
jobs_mongodb_migration 81.14% <18.91%> (-2.32%) ⬇️
libs_libcommon 91.40% <ø> (ø)
services_admin 87.12% <ø> (ø)
services_api 90.13% <ø> (ø)
workers_datasets_based 92.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/libcommon/src/libcommon/queue.py 96.10% <ø> (ø)
...grations/_20221117223000_cache_generic_response.py 36.17% <18.51%> (-28.70%) ⬇️
.../migrations/_20221116133500_queue_job_add_force.py 52.94% <20.00%> (-21.61%) ⬇️
...grations/_20230126164900_queue_job_add_priority.py 52.94% <20.00%> (-23.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix?

What about also requiring to run pull requests only if the base branch is main?

@severo
Copy link
Collaborator Author

severo commented Feb 1, 2023

What about also requiring to run pull requests only if the base branch is main?

Sometimes we do PR against a branch used in another PR (which might be a bad idea and we should instead do the PR against main and rebase). In that case the CI would not run.

I think we can let it that way, not sure if it's really an issue to run the CI on other branches

@severo severo merged commit 89a4510 into main Feb 2, 2023
@severo severo deleted the fix-ci branch February 2, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants