update the logic to skip a job #761
Conversation
Codecov ReportBase: 92.01% // Head: 92.02% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #761 +/- ##
=======================================
Coverage 92.01% 92.02%
=======================================
Files 33 33
Lines 2204 2206 +2
=======================================
+ Hits 2028 2030 +2
Misses 176 176
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This kind of error should lead to retrying the job.
|
it's easier to list the reasons for which we want to run a job, instead of the reason to skip it
Instead of retrying for any non-successful response in the cache, we only retry if the error is in the list of "retry-able" errors. Also: refactor the logic and add complete tests
severo
force-pushed
the
skip_job_even_on_error
branch
from
7a43f9d to
f8e43f1
Compare
severo
changed the title
| return False | ||
| return dataset_git_revision is not None and cached_response["dataset_git_revision"] == dataset_git_revision |
There was a problem hiding this comment.
Can we also make sure to not emit jobs if this condition is met ? This could help making the queue less full of unnecessary jobs
There was a problem hiding this comment.
Yes, sure, I'd planned to do it for #736. But I'm trying to do small PRs, I think it will work better now that we work as a team
Instead of retrying for any non-successful response in the cache, we
only retry if the error is in the list of "retry-able" errors. Also:
refactor the logic and add complete tests