Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dependencies lid.py, io.py #239 #241

Merged
merged 2 commits into from
Jul 8, 2024
Merged

add dependencies lid.py, io.py #239 #241

merged 2 commits into from
Jul 8, 2024

Conversation

aiqwe
Copy link
Contributor

@aiqwe aiqwe commented Jul 8, 2024

follow up #239

  • In case of using lid, fasttext is required
  • when we use model property, we use fasteners (in io.py)

two dependency checks added 😀.

@aiqwe aiqwe mentioned this pull request Jul 8, 2024
Closed
@aiqwe @guipenedo
Update src/datatrove/utils/lid.py
bd4f45b 
Co-authored-by: Guilherme Penedo <[email protected]>
aiqwe
aiqwe commented Jul 8, 2024
View reviewed changes
Copy link
Contributor Author

@aiqwe aiqwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@guipenedo
Copy link
Collaborator

ty!

@guipenedo guipenedo merged commit 55a9072 into huggingface:main Jul 8, 2024
@aiqwe aiqwe deleted the add_lid_dependencies branch January 6, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guipenedo guipenedo guipenedo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aiqwe @guipenedo