Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates quiz for unit 6 #429

Merged
merged 6 commits into from
Dec 6, 2023

Conversation

josejuanmartinez
Copy link
Contributor

This PR aims to add a quiz section for Unit 6, missing in the Deep RL course.

@josejuanmartinez josejuanmartinez changed the title Create quiz for unit 6 Creates quiz for unit 6 Dec 3, 2023
Copy link
Member

@simoninithomas simoninithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there 👋 thanks for the quiz.

To be able to work you need also to update _toctree..yml

https://github.com/huggingface/deep-rl-class/blob/main/units/en/_toctree.yml




### Q6: What is `Advantege` in the A2C method?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

explain: "If a reward signal is biased, it means the reward signal we get differs from the real reward we should be getting from an environment",
correct: false,
},
,
Copy link
Member

@simoninithomas simoninithomas Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's this comma who created the bug (line 36)

Copy link
Member

@simoninithomas simoninithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update 🤗

There's still a bug in the course generation, I suppose it comes from quiz line 36.
I also pointed a typo

Thanks

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@simoninithomas
Copy link
Member

Perfect, I merge it thanks again 🤗

@simoninithomas simoninithomas merged commit 64e049c into huggingface:main Dec 6, 2023
1 check passed
@josejuanmartinez josejuanmartinez deleted the unit-6-quiz branch December 6, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants