-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creates quiz for unit 6 #429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there 👋 thanks for the quiz.
To be able to work you need also to update _toctree..yml
https://github.com/huggingface/deep-rl-class/blob/main/units/en/_toctree.yml
units/en/unit6/quiz.mdx
Outdated
|
||
|
||
|
||
### Q6: What is `Advantege` in the A2C method? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo
units/en/unit6/quiz.mdx
Outdated
explain: "If a reward signal is biased, it means the reward signal we get differs from the real reward we should be getting from an environment", | ||
correct: false, | ||
}, | ||
, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's this comma who created the bug (line 36)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update 🤗
There's still a bug in the course generation, I suppose it comes from quiz line 36.
I also pointed a typo
Thanks
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Perfect, I merge it thanks again 🤗 |
This PR aims to add a quiz section for Unit 6, missing in the Deep RL course.