-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] ConsisID #10140
[core] ConsisID #10140
Conversation
@a-r-r-o-w Do we need to create a branch of |
|
@a-r-r-o-w @HuggingFaceDocBuilderDev hi, I have add consisid to this branch, can you help us to reveiew the code? Is there anything else I missed?
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
@a-r-r-o-w @hlky hi, what should I do next? |
to do:
|
@SHYuanBest Great work on the changes! We will try and integrate this soon and target it for next diffusers release (we have one this week, which is why we've been very busy). On your end, I think we are mostly good with the changes, and just need to address some minor concerns for diffusers-side integration. I will let YiYi comment and do her review first and then we can tackle the remaining things |
@a-r-r-o-w @yiyixuxu That's great, much thanks for your great support! Looking forward to merge. |
Gentle ping @yiyixuxu |
Could you help review the code and merge? Thanks @yiyixuxu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@a-r-r-o-w Hi, it seem that yiyixuxu have approved the changes, could you help merge https://huggingface.co/datasets/huggingface/documentation-images/discussions/406 (so that i can update the doc links) and tackle the remaining things, thansk! |
@SHYuanBest I've merged the doc PR just now :) Will do some last refactors after your changes and proceed to merge. I think it's okay to not have a conversion script in this specific case, so please don't worry about that |
@a-r-r-o-w Thanks a lot! And have update the docs link. |
@SHYuanBest Could you give the latest changes a look? It seems to be working for me locally as expected. The major changes in refactor are:
|
@a-r-r-o-w Thanks, I have looked the latest changs, it is good to me and the code can run nomally as expected. |
What does this PR do?
Add support for ConsisID (#10100)
Paper: https://arxiv.org/abs/2411.17440
Project: https://pku-yuangroup.github.io/ConsisID
Code: https://github.com/PKU-YuanGroup/ConsisID
Demo: https://huggingface.co/spaces/BestWishYsh/ConsisID-preview-Space
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.