-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] make tests device-agnostic (part 3) #10437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @faaany. I've left a couple comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some more suggestions and comments. Happy to assist with replicating the requested changes to all areas, let me know!
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Co-authored-by: hlky <[email protected]>
Thanks so much for the suggestions! code updated. And for further replication, I will submit a follow-up PR today. And for the rest, I would be very happy if you could help. |
Do you really need "BACKEND_RESET_MAX_MEMORY_ALLOCATED"? This function will all |
We can look at this in another PR. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very promising! Thank you!
Have you run the tests for which the changes are being introduced in this PR?
yes, I run the tests on xpu and except |
@faaany |
sure, let me update. |
Hi @sayakpaul @hlky @DN6 , could you do final-round review? Since I will have follow-up PRs, it would be great that it could be merged this week. Thanks a lot! |
Hi folks, any feedback? |
What does this PR do?
Followed by PR #9399 and #9400 , this PR further makes current cuda-only tests device-agnostic.