-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HF_HOME in push_tests_mps
workflow
#10442
base: main
Are you sure you want to change the base?
Conversation
Does removing them help launch the tests? Could we maybe trigger it manually? |
I don't know if we can trigger it manually. Currently the tests launch on push to https://github.com/huggingface/diffusers/actions/runs/12588771861/job/35087350062#step:7:8211 Most pipeline tests seem to be failing and there are some warnings
It suggests some pipeline tests are failing because of it, but there are no tracebacks for individual test failures, probably due to the segfault. |
Sorry should have been clearer. What we could do to ensure the MPS stuff runs successfully:
Does this sound good? |
Nice seems like the tests are getting picked up? We can let them run and fix anything in a follow-up PR? WDYT? |
There are still some failures so far, I'll compare to one of the last runs to check if anything is fixed. I think priority is fixing the segfault but I see no indication of anything that could be causing it. We could separate the tests like models, pipelines, schedulers, might help break it down as there are a lot of |
Makes sense and okay for me to tackle that in this PR. Thanks! Let me know if I can help. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
What does this PR do?
Reviewing mps test failures it looks like
HF_HOME
is an issue. Normally we are running Docker and mount the cache, we aren't using Docker for mps.Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@sayakpaul