Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Loading] Ignore unneeded files #1107

Merged
merged 2 commits into from
Nov 2, 2022
Merged

[Loading] Ignore unneeded files #1107

merged 2 commits into from
Nov 2, 2022

Conversation

patrickvonplaten
Copy link
Contributor

No description provided.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 2, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

anton-l
anton-l approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@anton-l anton-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Should we exclude *.ckpt too maybe?

patil-suraj
patil-suraj approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@patrickvonplaten
Copy link
Contributor Author

patrickvonplaten commented Nov 2, 2022 •
edited
Loading

Very nice! Should we exclude *.ckpt too maybe?

They should be excluded automatically because they'll never be inside any folder. The allow pattern only allows for folders as defined in the model_index.json

@patrickvonplaten patrickvonplaten merged commit c39a511 into main Nov 2, 2022
@patrickvonplaten patrickvonplaten deleted the ignore_flax_files_for_pytorch branch November 2, 2022 18:20
pcuenca added a commit that referenced this pull request Nov 26, 2022
@pcuenca
Fix Flax from_pt.
5c82a41 
It worked for models but not for pipelines.
Accidentally broken in #1107.
@pcuenca pcuenca mentioned this pull request Nov 26, 2022
Merged
pcuenca added a commit that referenced this pull request Nov 28, 2022
@pcuenca
Fix Flax from_pt (#1436)
8930013 
Fix Flax `from_pt`.

It worked for models but not for pipelines.
Accidentally broken in #1107.
sliard pushed a commit to sliard/diffusers that referenced this pull request Dec 21, 2022
@pcuenca @sliard
Fix Flax from_pt (huggingface#1436)
821fca2 
Fix Flax `from_pt`.

It worked for models but not for pipelines.
Accidentally broken in huggingface#1107.
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@patrickvonplaten
[Loading] Ignore unneeded files (huggingface#1107)
7a237b0 
* [Loading] Ignore unneeded files

* up
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@pcuenca
Fix Flax from_pt (huggingface#1436)
6493ed8 
Fix Flax `from_pt`.

It worked for models but not for pipelines.
Accidentally broken in huggingface#1107.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patil-suraj patil-suraj patil-suraj approved these changes

@anton-l anton-l anton-l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrickvonplaten @HuggingFaceDocBuilderDev @anton-l @patil-suraj