-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a few fix for SingleFile tests #9522
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@@ -541,6 +542,7 @@ def infer_diffusers_model_type(checkpoint): | |||
def fetch_diffusers_config(checkpoint): | |||
model_type = infer_diffusers_model_type(checkpoint) | |||
model_path = DIFFUSERS_DEFAULT_PIPELINE_PATHS[model_type] | |||
model_path = copy.deepcopy(model_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
making a copy that we won't accidently modify the DIFFUSERS_DEFAULT_PIPELINE_PATHS
so here is an example, we modified the output of fetch_diffusers_config
in place
subfolder = subfolder or config.pop( |
this is likely to happen if it had not already, so we should go through the single file code and see if there are more places might cause this type of errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks great! Good to see a separate org for maintaining the runway checkpoints 🥹
I've been looking at some failing tests too (such as this, and similar) but cannot replicate locally either. Will take a deeper look at some of the remaining failing tests soon too
* update sd15 repo * update more
* update sd15 repo * update more
This PR:
Lykon/dreamshaper-8
tostable-diffusion-v1-5/stable-diffusion-v1-5
.Lykon/dreamshaper-8
actually has a different config than the original SD1.5, which caused test failures such as https://github.com/huggingface/diffusers/actions/runs/10985616735/job/30497746524#step:6:30045stable-diffusion-v1-5/stable-diffusion-v1-5
and "stable-diffusion-v1-5/stable-diffusion-inpainting", the "Jiali/stable-diffusion-1.5" does not contain variant, which caused failures such as https://github.com/huggingface/diffusers/actions/runs/10985616735/job/30497746524#step:6:30048did not fix this https://github.com/huggingface/diffusers/actions/runs/10985616735/job/30497746524#step:6:30055
looked into it but it is what it is, for upcaler there is a discrepancy in sample_size config between vae and unet, we will decide when @DN6 is back
there are a lot of internet os errors that I cannot reproduce on my machine, so did not address in this PR. will look into if it persist