-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pipeline] CogVideoX-Fun Control #9671
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! awesome! so we did not need to update the model at all?
I left comments about scheduler
src/diffusers/pipelines/cogvideo/pipeline_cogvideox_fun_control.py
Outdated
Show resolved
Hide resolved
nope, no changes at all :) |
Thank you for the cc. How can I help you? |
Hi @bubbliiiing. Thanks for your awesome work! I would be grateful if you could give this PR a review and verify its correctness and if it's compatible with the original pipeline/scripts. Happy to merge this if you think it's good (and subsequently the inpainting models in a different PR) :) Also would love to collaborate on any future releases you are planning on and if we can help with training/finetuning in any way as @sayakpaul and I are looking into it too alongside the CogVideoX team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
src/diffusers/pipelines/cogvideo/pipeline_cogvideox_fun_control.py
Outdated
Show resolved
Hide resolved
…l.py Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Just a single a comment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This is the test result after I simply modified the prompt words, it is very good. |
@bubbliiiing thanks for reviewing and for testing this PR. Would it be possible to also add a note about |
Of course! Could you provide me with an example of adding "diffusers support"? I would like to add it in the same way. |
I understand. I'll submit a PR to the CogVideoX-Fun repository. |
* cogvideox-fun control * make style * make fix-copies * karras schedulers * Update src/diffusers/pipelines/cogvideo/pipeline_cogvideox_fun_control.py Co-authored-by: Steven Liu <[email protected]> * Update docs/source/en/api/pipelines/cogvideox.md Co-authored-by: Steven Liu <[email protected]> * apply suggestions from review --------- Co-authored-by: Steven Liu <[email protected]> Co-authored-by: Sayak Paul <[email protected]>
What does this PR do?
Adds support for CogVideoX-Fun Pose Control models
alibaba-pai/CogVideoX-Fun-V1.1-2b-Pose
alibaba-pai/CogVideoX-Fun-V1.1-5b-Pose
Usage
hiker.mp4
output.mp4
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@bubbliiiing @yunkchen