Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] fix import of EntryNotFoundError. #9676

Merged
merged 2 commits into from
Oct 15, 2024
Merged

[Chore] fix import of EntryNotFoundError. #9676

merged 2 commits into from
Oct 15, 2024

Conversation

sayakpaul
Copy link
Member

@sayakpaul sayakpaul requested a review from Wauplin October 15, 2024 04:44
Copy link
Collaborator

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -3,7 +3,7 @@

import pandas as pd
from huggingface_hub import hf_hub_download, upload_file
from huggingface_hub.utils._errors import EntryNotFoundError
from huggingface_hub.utils import EntryNotFoundError
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from huggingface_hub.utils import EntryNotFoundError
from huggingface_hub.errors import EntryNotFoundError

This should be even more future-proof (though it's already fine :) ).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires a library-wide change and I will prefer a separate PR for that.

@sayakpaul sayakpaul merged commit 99d8747 into main Oct 15, 2024
10 checks passed
@sayakpaul sayakpaul deleted the fix-benchmarks branch October 15, 2024 08:37
sayakpaul added a commit that referenced this pull request Dec 23, 2024
fix import of EntryNotFoundError.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants