Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[widgets] Fix copy-paste error resulting in Sentence Similarity widget failure #732

Closed

Conversation

tomaarsen
Copy link
Member

Hello!

Pull Request overview

  • Fix copy-paste error resulting in Sentence Similarity widget failure

Bug Details

Currently, the Sentence Similarity widget is not filled with any content:
image
E.g. for https://huggingface.co/tomaarsen/mpnet-base-all-nli-triplet

This occurs regardless of whether the widget values are overridden by the README.md metadata (like this) or not.

After this PR

I've narrowed this down to the fix applied in this PR. After applying it, I was able to see the specified widget data:
image

And when I didn't override the default options:
image

cc @osanseviero

  • Tom Aarsen

@coyotte508
Copy link
Member

Hi! The widgets package has been moved to https://github.com/huggingface/moon-landing/tree/main/packages/widgets, you can make your PR there

@coyotte508 coyotte508 closed this Jun 3, 2024
@tomaarsen
Copy link
Member Author

Apologies, I was unaware! Will create a new PR there.

@osanseviero osanseviero mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants