Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging mistake where "dynamic" is logged if static quantization is performed #192

Merged
merged 1 commit into from
May 16, 2022

Conversation

regisss
Copy link
Contributor

@regisss regisss commented May 15, 2022

What does this PR do?

In optimum/onnxruntime/quantization.py, we currently have:

LOGGER.info(
    f"Creating {'dynamic' if quantization_config.is_static else 'static'} quantizer: {quantization_config}"
)

'dynamic' and 'static' should be swapped.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@regisss regisss requested a review from echarlaix May 15, 2022 23:19
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@echarlaix
Copy link
Collaborator

Good catch, thanks @regisss !

@echarlaix echarlaix merged commit cf91bd7 into huggingface:main May 16, 2022
@regisss regisss deleted the fix_print_error branch May 16, 2022 12:21
fxmarty pushed a commit to fxmarty/optimum that referenced this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants