FIX / Workflow: Fix Mac-OS CI issues #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
younesbelkada
changed the title
younesbelkada
commented
Apr 25, 2024
BenjaminBossan
pushed a commit
to BenjaminBossan/peft
that referenced
this pull request
Jun 18, 2024
We switched to MacOS 12 in huggingface#1680 because latest MacOS was moved to use the ARM Macs, which were not provided for Python 3.8 and 3.9. This should have been fixed by now. Of course, this means that CI no longer checks Intel Macs, but I think ARM Macs will be more relevant for most users.
younesbelkada
added a commit
that referenced
this pull request
Jun 18, 2024
This reverts commit 3d9529d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @pacman100 @BenjaminBossan
Freeze the mac-os to
mac-os-12temporarly, see: actions/setup-python#850