FIX: Reinstate PEFT_TYPE_TO_MODEL_MAPPING variable with deprecation #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for backwards compatibility: In huggingface#2282, PEFT_TYPE_TO_MODEL_MAPPING was removed as it was redundant with PEFT_TYPE_TO_TUNER_MAPPING. However, third party code could still use this mapping, e.g.: https://github.com/AutoGPTQ/AutoGPTQ/blob/6689349625de973b9ee3016c28c11f32acf7f02c/auto_gptq/utils/peft_utils.py#L8 Therefore, it is reinstated here, but a DeprecationWarning will be given if it's used.
BenjaminBossan
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
githubnemo
approved these changes
Jan 14, 2025
BenjaminBossan
deleted the
fix-reinstate-peft_type_to_model_mapping-variable-with-deprecation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for backwards compatibility: In #2282,
PEFT_TYPE_TO_MODEL_MAPPINGwas removed as it was redundant withPEFT_TYPE_TO_TUNER_MAPPING. However, third party code could still use this mapping, e.g.:https://github.com/AutoGPTQ/AutoGPTQ/blob/6689349625de973b9ee3016c28c11f32acf7f02c/auto_gptq/utils/peft_utils.py#L8
Therefore, it is reinstated here, but a
DeprecationWarningwill be given if it's used.