Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally remove the REGEXP from ByteLevel pre_tokenizer #931

Closed
Narsil opened this issue Mar 1, 2022 · 0 comments · Fixed by #939
Closed

Optionally remove the REGEXP from ByteLevel pre_tokenizer #931

Narsil opened this issue Mar 1, 2022 · 0 comments · Fixed by #939

Comments

@Narsil
Copy link
Collaborator

Narsil commented Mar 1, 2022

This is sort of done here:

https://github.com/huggingface/tokenizers/pull/896/files#diff-c2be5839194fbc7e052d4600684eeb35f0db504b5b4df6565f01057762e23774R46

There might be some changes which might make it better, like using None instead of "no_regexp" in Python.
(In RUST, since the regexp is hardcoded, and we definitely don't want to enable users to choose, since it should be done as another pre_tokenizer if you want custom regexp, going with the simple Enum instead of Option seems more correct as a first approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant