Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making the regex in ByteLevel optional. #939

Merged
merged 5 commits into from
Mar 18, 2022
Merged

Making the regex in ByteLevel optional. #939

merged 5 commits into from
Mar 18, 2022

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented Mar 5, 2022 •
edited
Loading

Fixes #931

@Narsil Narsil requested review from thomasw21, SaulLu and McPatate March 5, 2022 10:37
McPatate
McPatate reviewed Mar 7, 2022
View reviewed changes
tokenizers/src/pre_tokenizers/byte_level.rs Outdated Show resolved Hide resolved
tokenizers/src/pre_tokenizers/byte_level.rs Show resolved Hide resolved
tokenizers/src/pre_tokenizers/byte_level.rs Outdated Show resolved Hide resolved
tokenizers/src/pre_tokenizers/byte_level.rs Outdated Show resolved Hide resolved
tokenizers/src/pre_tokenizers/byte_level.rs Outdated Show resolved Hide resolved
@Narsil Narsil force-pushed the optional_regex_bytelevel branch from c9ac61a to 1d62f39 Compare March 17, 2022 09:50
@Narsil Narsil merged commit daa4dd2 into master Mar 18, 2022
@Narsil Narsil deleted the optional_regex_bytelevel branch March 18, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McPatate McPatate McPatate left review comments

@thomasw21 thomasw21 Awaiting requested review from thomasw21

@SaulLu SaulLu Awaiting requested review from SaulLu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optionally remove the REGEXP from ByteLevel pre_tokenizer
2 participants
@Narsil @McPatate