Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade macro_rules_attribute to 0.1.2 #1038

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

pacowong
Copy link
Contributor

@pacowong pacowong commented Aug 7, 2022

Changes

I've upgraded macro_rules_attribute to 0.1.2 so that cargo build can generate static libraries for more platforms.

Motivation

The change solves the following error when building a static library of tokenizer

Rust version: rustc 1.62.1 (e092d0b6b 2022-07-16)

....
   Compiling macro_rules_attribute v0.0.2
error[E0432]: unresolved imports `proc_macro::macro_rules_attribute`, `proc_macro::macro_rules_derive`
 --> /Users/paco/.cargo/registry/src/jackfan.us.kg-1ecc6299db9ec823/macro_rules_attribute-0.0.2/src/lib.rs:8:5
  |
8 |     macro_rules_attribute,
  |     ^^^^^^^^^^^^^^^^^^^^^ no `macro_rules_attribute` in the root
9 |     macro_rules_derive,
  |     ^^^^^^^^^^^^^^^^^^ no `macro_rules_derive` in the root

For more information about this error, try `rustc --explain E0432`.
error: could not compile `macro_rules_attribute` due to previous error
warning: build failed, waiting for other jobs to finish...

@Narsil Narsil requested a review from McPatate August 8, 2022 10:39
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 8, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Narsil Narsil merged commit 67c56ad into huggingface:main Aug 8, 2022
Narsil pushed a commit that referenced this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants