Modify Processor trait to support chaining.
#1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
0 modifications yet, everything will consume the vector. Every test should be green without any modifications.
Narsil
force-pushed
the
modify_processor_trait
branch
from
8d16889 to
c221192
Compare
mishig25
reviewed
Aug 24, 2022
|
Thank you @Narsil 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0 modifications yet, everything will consume the vector.
Every test should be green without any modifications.
I wanted to resurrect #1005 but I found myself having a real hard time making modifications and understanding what was what and why things were different when they were.
Instead I decided to start from scratch heavily inspiring from the PR instead.
This PR is the first step. It modifies the trait, and that' s it.
process_encodingsactually agnostic (meaning not fusing their returned results into 1 encoding when they can).Sequence.Each step will be in a different PR.
Edit companion PR for code linting : #1048