Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cargo.toml #1266

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Update Cargo.toml #1266

merged 1 commit into from
Jun 7, 2023

Conversation

chris-ha458
Copy link
Contributor

The only really relevant updates for me are

unicode-segmentation = "1.10"
regex = "1.8"

This is because the current dependency version unicode-segmentation 1.6 supports unicode 12
while 1.10 supports unicode 15 with a lot of CJK relevant changes in the meantime.

However, I did just added several ones that i thought were crucial.

anyway not that relevant in the first place since it seems due to dependencies updated versions were already used.
(most recent versions were already being used)

cargo update yield the following
Updating regex v1.8.1 -> v1.8.3
Updating regex-syntax v0.7.1 -> v0.7.2

cargo test, bench
python setup.py install

all passes on my end.

`cargo update` yield the following
Updating regex v1.8.1 -> v1.8.3
Updating regex-syntax v0.7.1 -> v0.7.2
@ArthurZucker
Copy link
Collaborator

Cool for me, let's wait for @Narsil to come back as he is more knowledgable on what we should keep!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 1, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for this. ``bindings/python` might need the same treatment.

@Narsil Narsil merged commit f85e846 into huggingface:main Jun 7, 2023
@chris-ha458 chris-ha458 deleted the cargo_packages branch June 7, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants