Enable fancy regex #1586
Merged
Enable fancy regex #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
reviewed
Aug 1, 2024
Comment on lines
+37
to
+63
| impl Pattern for &Regex { | ||
| fn find_matches( | ||
| &self, | ||
| inside: &str, | ||
| ) -> Result<Vec<(Offsets, bool)>, Box<dyn Error + Send + Sync + 'static>> { | ||
| if inside.is_empty() { | ||
| return Ok(vec![((0, 0), false)]); | ||
| } | ||
|
|
||
| let mut prev = 0; | ||
| let mut splits = Vec::with_capacity(inside.len()); | ||
| for match_ in self.find_iter(inside) { | ||
| let match_ = match_?; | ||
| let start = match_.start(); | ||
| let end = match_.end(); | ||
| if prev != start { | ||
| splits.push(((prev, start), false)); | ||
| } | ||
| splits.push(((start, end), true)); | ||
| prev = end; | ||
| } | ||
| if prev != inside.len() { | ||
| splits.push(((prev, inside.len()), false)) | ||
| } | ||
| Ok(splits) | ||
| } | ||
| } |
ArthurZucker
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tokenizersenable the use of 2 regex engines.The main supported one is
onig, the other one is unstable and used byunstable_wasmand it'sfancy_regex(onig being C cannot be compiled as is. on wasm targets).This PR fixes the code so that it leverages
tokenizersregexes instead ofonigdirectly in the python bindings, which allows swapping one for the other.Unfortunately
FancyRegexis slower.