Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformers breaks when running setup.py #26276

Closed
4 tasks
AdamLouly opened this issue Sep 19, 2023 · 5 comments · Fixed by #26301
Closed
4 tasks

Transformers breaks when running setup.py #26276

AdamLouly opened this issue Sep 19, 2023 · 5 comments · Fixed by #26301

Comments

@AdamLouly
Copy link
Contributor

System Info

Running python setup.py install in transformers folder throws this error:

error: huggingface-hub 0.17.2 is installed but huggingface_hub<0.17,>=0.16.4 is required by {'tokenizers'}

This starts happening after merging this PR where line 175 was changed from:
from "tokenizers>=0.11.1,!=0.11.3,<0.14",
to "tokenizers>=0.14,<0.15",

#23909

when I change it back manually it works fine.

Who can help?

No response

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction

Running python setup.py install in transformers folder

Expected behavior

error: huggingface-hub 0.17.2 is installed but huggingface_hub<0.17,>=0.16.4 is required by {'tokenizers'}

@ArthurZucker
Copy link
Collaborator

A quick fix: update huggingface_hub . On our side we should update the dependency requirement. Thanks for reporting!

@AdamLouly
Copy link
Contributor Author

@ArthurZucker have you tested re installing Transformers after this update?
I tested and its still failing.

huggingface-hub>=0.16.4,<1.0 won't solve the issue:
huggingface_hub<0.17,>=0.16.4 is required by {'tokenizers'}

because its installing huggingface_hub 0.17.4 and that will break it.

@ArthurZucker
Copy link
Collaborator

I think tokenizers has to be updated at this point, since it's not using the latest dependency. cc @Narsil any reason why we limited to HF hub 0.17?

@AdamLouly
Copy link
Contributor Author

@ArthurZucker Any updates on this?

@ArthurZucker
Copy link
Collaborator

Yep, this PR was merged in tokenizers, we just need a release and this will be adressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants