Let's allow hf_hub < 1.0 #1344
Merged
Let's allow hf_hub < 1.0 #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
@ArthurZucker when will this be merged? It's painful having to upgrade and downgrade back and forth to train and then upload models |
Narsil
reviewed
Oct 2, 2023
bindings/python/pyproject.toml
Outdated
| @@ -26,7 +26,7 @@ dynamic = [ | |||
| 'license', | |||
| 'readme', | |||
| ] | |||
| dependencies = ["huggingface_hub>=0.16.4,<0.17"] | |||
| dependencies = ["huggingface_hub>=0.16.4,<1.0"] | |||
There was a problem hiding this comment.
No, we need to allow for breaking changes in huggingface_hub meaning we can do >=0.17,<0.18 instead.
ArthurZucker
commented
Oct 2, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to be more permissive with HF hub version