Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the doc_build_test job #14774

Merged
merged 8 commits into from
Dec 15, 2021
Merged

Fix the doc_build_test job #14774

merged 8 commits into from
Dec 15, 2021

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Dec 15, 2021

What does this PR do?

This PR fixes the build_doc_test job by installing Transformers from the branch instead of master. This then triggers a problem if we do an editable install because the pull-request environment of GitHub actions is read-only and a Python package. Thankfully just removing the -e solves the issue!

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! Thanks @sgugger

@LysandreJik LysandreJik merged commit 7e61d56 into master Dec 15, 2021
@LysandreJik LysandreJik deleted the test_doc_build_branch branch December 15, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants