[Generate] correct encoder_outputs are passed without attention_mask #14980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickvonplaten
requested review from
Narsil and
sgugger
and removed request for
Narsil
sgugger
approved these changes
Dec 29, 2021
tests/test_generation_utils.py
Outdated
Comment on lines
1902
to
1904
| output_sequences_with_mask = model.generate( | ||
| encoder_outputs=encoder_outputs, attention_mask=attention_mask | ||
| ).cpu() |
There was a problem hiding this comment.
As usual, when formatted like this by black, I'd go for two lines :-)
Narsil
approved these changes
Dec 29, 2021
| framework="pt", | ||
| ) | ||
|
|
||
| ds = load_dataset("hf-internal-testing/librispeech_asr_dummy", "clean", split="validation").sort("id") |
There was a problem hiding this comment.
yeah since it different versions datasets might break the order
There was a problem hiding this comment.
This seems like a very odd thing in datasets that order could be messed up by subsequent versions...
There was a problem hiding this comment.
@anton-l and I have experienced this now a couple of times so tat we'll just make sure this way
…ckvonplaten/transformers into correct_generate_edge_case
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
Jan 6, 2022
…uggingface#14980) * [Generate] correct encoder_outputs are passed without attention_mask * Apply suggestions from code review * up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Very very edge case is solved in this PR which occurs if
"encoder_outputs"is passed in combination without passing"attention_mask", but a model that accepts an"attention_mask".Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.