Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] Correct Wav2Vec2 & WavLM tests #15015
[Tests] Correct Wav2Vec2 & WavLM tests #15015
Changes from all commits
265896a
824b719
e9fb90c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't nicely load mp3 at the moment with
datasets
-> let's just use a.wav
file for nowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feed forward chunking is not even implemented by WavLM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this was incorrect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did it ever pass? If so, it would be nice to checkout an earlier commit on which it passed and check the difference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really know what was going on here. I'm sure though that the checkpoint works correctly as the model gives great results when fine-tuning -> see: https://huggingface.co/patrickvonplaten/wavlm-libri-clean-100h-large (tested on dec 17th: https://huggingface.co/patrickvonplaten/wavlm-libri-clean-100h-large/commit/a1b7ace90561bafd37167ca73c72833ad345963f) and there hasn't been a model change in the checkpoint's repo since december 16th: https://huggingface.co/microsoft/wavlm-large/commit/38b04afdf061607fdccc24c4ca4e8c3ae339012f
So the checkpoint is fine. Really not sure what was/is going on with this test. Will monitor in the coming days