Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change unpacking of TF layoutlm inputs to use decorator #16112

Merged
merged 3 commits into from
Mar 15, 2022
Merged

Change unpacking of TF layoutlm inputs to use decorator #16112

merged 3 commits into from
Mar 15, 2022

Conversation

vumichien
Copy link
Contributor

What does this PR do?

As part of #16051 this PR changes the unpacking of the inputs of TF layoutlm to use the decorator instead.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@Rocketknight1 @gante

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 13, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you so much! I have the same comments as in the other PR:

  1. Tests are failing due to formatting -- make fixup should fix it
  2. Can you confirm that RUN_SLOW=1 py.test -vv tests/[model_name]/test_modeling_tf_[model_name].py runs?
  3. Sorry to be picky about this -- other models have been adding @unpack_inputs as the top decorator, can I ask you to move it to the top (for consistency)?

Finally, one of the models you touched is RAG, whose tests are suuuuuper slow (like 1hr slow, needing >16GB of RAM) -- let me know if you want me to run the tests 🙏

@vumichien
Copy link
Contributor Author

vumichien commented Mar 14, 2022

Yah, I agree Rag's test is suppper slow :( . Anyway, let me run all the tests again and I will commit when they are done

@gante
Copy link
Member

gante commented Mar 14, 2022

Yah, I agree Rag's test is suppper slow :( . Anyway, let me run all the tests again and I will commit when they are done

I'm assuming all tests have passed, since you've made a commit -- is this correct? :D

@vumichien
Copy link
Contributor Author

Yeah, all the test have passed :D

@gante gante merged commit 611d3a0 into huggingface:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants