-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed inputs_processing and replaced with decorator for lxmert #16414
Conversation
All tests pass after running
|
The documentation is not available anymore as the PR was closed or merged. |
Hi again @gante remade all the changes in this fresh PR..so sorry that you need to review once again. In turn I realized I need to learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This time all good 🔥 Thank you for the contribution!
As for git
skills -- yeah, they are super important for these large projects. As you've seen in your other PR, one wrong command can create a lot of work. Practice makes it perfect 💪
What does this PR do?
Replaces usage of
inputs_processing
with decoratorunpack_input
inlxmert
See #16051
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@gante