Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type hints for pytorch models #17064

Merged
merged 4 commits into from
May 5, 2022
Merged

type hints for pytorch models #17064

merged 4 commits into from
May 5, 2022

Conversation

robotjellyzone
Copy link
Contributor

@robotjellyzone robotjellyzone commented May 3, 2022 •
edited
Loading

What does this PR do?

Fixes #16059 :

Added type hints for pytorch models - canine, convbert, convnext, encoder_decoder, gpt2, gptj, megatron_bert, mobilebert, perceiver, retribert, swin, transfo_xl & van.

For the code quality, I ran make fixup and reformatted the codes & also resolved consistency problems across other models [which were - decision_transformer, glpn, maskformer, & segformer]

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@Rocketknight1

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 3, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

Rocketknight1
Rocketknight1 approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks great! I made a few comments, but some of them are just questions. The main one was the introduction of the extra argument - are you sure that's correct?

@robotjellyzone
Copy link
Contributor Author

robotjellyzone commented May 4, 2022 •
edited
Loading

@Rocketknight1 I have added the changes suggested by you & all checks are passing!

@Rocketknight1
Copy link
Member

Looks great, thanks for the PR!

@Rocketknight1 Rocketknight1 merged commit 45360e1 into huggingface:main May 5, 2022
@robotjellyzone robotjellyzone deleted the type_hint_pytorch branch May 6, 2022 12:22
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
@robotjellyzone @elusenji
type hints for pytorch models (huggingface#17064)
b9fd93e 
* type hints for pytorch models

* fixed import error

* fixed some errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rocketknight1 Rocketknight1 Rocketknight1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing type hints
3 participants
@robotjellyzone @HuggingFaceDocBuilderDev @Rocketknight1