Include a comment to reflect Amy's contributions #17689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Amy Roberts <[email protected]>
|
The documentation is not available anymore as the PR was closed or merged. |
|
@sgugger forgot tagging you. |
|
Hey @sayakpaul, that's really admirable, thank you for that. I personally don't think it needs to be in a comment, as the code isn't where attribution lies, and would clutter the code with non-technical details. The attribution lives in git, and that's where we should do something if you want to add a mention of Amy for those lines of code. How about doing something as simple as switching a if/else statement (or any other kind of no-op change) and having Amy as author/co-author? |
Co-authored by: Amy Roberts <[email protected]>
|
@LysandreJik see if it's okay now. |
sgugger
approved these changes
Jun 14, 2022
|
Let's see if this works, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a note to
src/transformers/modeling_tf_pytorch_utils.pyto reflect @amyeroberts's contributions suggested in #17571. It is an oversight on my end that I forgot to mention in the first place.I hope it's viewed as a mistake and not as a plagiarism attempt.