Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the model type check in DocumentQuestionAnswering to support Donut #19027

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

ankrgyl
Copy link
Contributor

@ankrgyl ankrgyl commented Sep 14, 2022

What does this PR do?

Prior to this change, you'd see an error while instantiating a pipeline with Donut:

In [3]: pipe = pipeline(task="document-question-answering", model='naver-clova-ix/donut-base-finetuned-docvqa')
The model 'VisionEncoderDecoderModel' is not supported for document-question-answering. Supported models are ['LayoutLMForQuestionAnswering', 'LayoutLMv2ForQuestionAnswering', 'LayoutLMv3ForQuestionAnswering'].

because it's not part of AutoModelForDocumentQuestionAnswering. I've moved around that check so that it does not apply to the Donut case.

Fixes #18926

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@NielsRogge @Narsil

@NielsRogge NielsRogge requested a review from Narsil September 14, 2022 12:30
Copy link
Contributor

@NielsRogge NielsRogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, looks clean to me!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 14, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@sgugger sgugger merged commit 216b2f9 into huggingface:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow ups to DocumentQuestionAnswering Pipeline
4 participants