Fix docstrings for TF BLIP

[Rocketknight1]

Some of the docstrings were still a bit PyTorchy, this is fixed now! (cc @ydshieh)

[innat]

@Rocketknight1 Thanks for adding tf-blip.
PS. in case you're interested to contribute keras-team/keras-hub#941

[ydshieh]

@Rocketknight1 I tried to re-run the CI, but it still fails. Could you push an empty commit to trigger it maybe?

[HuggingFaceDocBuilderDev]

The documentation is not available anymore as the PR was closed or merged.

[Rocketknight1]

@ydshieh tests are passing now! Can you approve the PR?

[ydshieh]

@Rocketknight1 When I run the doctest

python3 -m pytest -v --make-reports doc_tests_gpu --doctest-modules src/transformers/models/blip/modeling_tf_blip.py::transformers.models.blip.modeling_tf_blip.TFBlipForConditionalGeneration.generate -sv --doctest-continue-on-failure --doctest-glob="*.mdx"

I got

Expected:
    two cats are laying on a couch
Got:
    two cats sleeping on a couch

[ydshieh]

Also, the changes are not just docstrings. After looking at the changes, I am wondering why we don't have CI failures (i.e. the usual testing).

It turns out that we do have some failures
https://github.com/huggingface/transformers/actions/runs/4653835201/jobs/8235101265

@Rocketknight1 Do you want to verify/fix those in this same PR? (probably already fixed as CircleCI is green?)

[Rocketknight1]

Oh, that's very odd - I wonder why it's not visible in the CI? I'll take a look!

[ydshieh]

Thank you @Rocketknight1 . I am also confused why CircleCI is green but failed on daily CI.

[Rocketknight1]

@ydshieh tests should pass now! The cause was some expected values in the tests being wrong. I copied the right ones from the torch tests and now everything is passing locally, so hopefully the CI will agree.

[Rocketknight1]

The doctests are weird, though - I think some of them were broken in PyTorch too. Working on it!

[ydshieh]

Thanks @Rocketknight1 I will double check. But do you figure out (some of) tests pass on CircleCI but fails on daily CI - the pt<->tf equivalence tests also run on CircleCI. We should see they fail on it (as they fail on daily CI).

[ydshieh]

For the doctest, we still get

Expected:
    two cats are laying on a couch
Got:
    two cats sleeping on a couch

for TFBlipForConditionalGeneration.generate.

Regarding the modeling tests - all tests pass now 🥳

[ydshieh]

LGTM, thanks @Rocketknight1 on this. A doctest value still needs to be updated I think.

Also wondering why we don't see test failure on CircleCI previously. If you know, please let me know 🙏 .

[Rocketknight1]

@ydshieh should be resolved now!

[ydshieh]

Thank you @Rocketknight1 again, our 2 cute cats can finally sleep well now.