Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wav2Vec2-Conf / LLaMA] Style fix #26188

Merged
merged 3 commits into from
Sep 18, 2023
Merged

[Wav2Vec2-Conf / LLaMA] Style fix #26188

merged 3 commits into from
Sep 18, 2023

Conversation

sanchit-gandhi
Copy link
Contributor

What does this PR do?

Small style fix to stay consistent with the rest of the modelling code: torch.nn -> nn

@sanchit-gandhi sanchit-gandhi mentioned this pull request Sep 15, 2023
Merged
7 tasks
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 15, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

ArthurZucker
ArthurZucker reviewed Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is also present in Llama's torch.nn.embedding used for ROPE if you want to adresse this as well

@sanchit-gandhi sanchit-gandhi changed the title [Wav2Vec2-Conf] Style fix [Wav2Vec2-Conf / LLaMA] Style fix Sep 18, 2023
ArthurZucker
ArthurZucker approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@sanchit-gandhi sanchit-gandhi merged commit e4e55af into huggingface:main Sep 18, 2023
@sanchit-gandhi sanchit-gandhi deleted the wav2vec2-conf-clean branch September 18, 2023 16:27
@sanchit-gandhi
Copy link
Contributor Author

CI went red on main: the permisson model wasn't checked as part of the PR. Needed to rebase to include it: #26228

MKhalusova pushed a commit to MKhalusova/transformers that referenced this pull request Sep 19, 2023
@sanchit-gandhi @MKhalusova
[Wav2Vec2-Conf / LLaMA] Style fix (huggingface#26188)
5f19eaf 
* torch.nn -> nn

* fix llama

* copies
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
@sanchit-gandhi @parambharat
[Wav2Vec2-Conf / LLaMA] Style fix (huggingface#26188)
f182043 
* torch.nn -> nn

* fix llama

* copies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanchit-gandhi @HuggingFaceDocBuilderDev @ArthurZucker