Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMD] Add initial version for run_tests_multi_gpu #26346

Merged
merged 21 commits into from
Oct 3, 2023
Merged

[AMD] Add initial version for run_tests_multi_gpu #26346

merged 21 commits into from
Oct 3, 2023

Conversation

mfuntowicz
Copy link
Member

No description provided.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 22, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@mfuntowicz mfuntowicz marked this pull request as ready for review October 2, 2023 08:42
ydshieh
ydshieh reviewed Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We can simplify the workflow file a bit.

Also, would love to know how the runners are set up, but it could be an internal documentation.

@mfuntowicz mfuntowicz force-pushed the ci-amdgpu-multi-gpu-tests branch from 64c0a65 to 669b624 Compare October 2, 2023 13:11
LysandreJik
LysandreJik approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both for your work on this :)

ydshieh
ydshieh approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mfuntowicz mfuntowicz merged commit 3632fb3 into main Oct 3, 2023
@mfuntowicz mfuntowicz deleted the ci-amdgpu-multi-gpu-tests branch October 3, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydshieh ydshieh ydshieh approved these changes

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mfuntowicz @HuggingFaceDocBuilderDev @ydshieh @LysandreJik @glegendre01