added support for gradient checkpointing in ESM models #26386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rocketknight1
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Looks good to me, and the test looks clean too!
Amy is out but pinging @LysandreJik for core maintainer review.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
LysandreJik
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #24602
Adds gradient checkpointing support for ESM models
Before submitting
Pull Request section?
to it if that's the case.
Issue link: Support gradient checkpointing for ESM models #24602
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@Rocketknight1 @amyeroberts : Please review and suggest any required changes, thanks.