-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update runs-on
in workflow files
#26435
Conversation
.github/workflows/doctests.yml
Outdated
@@ -20,7 +20,7 @@ env: | |||
|
|||
jobs: | |||
run_doctests: | |||
runs-on: [self-hosted, doc-tests-gpu] | |||
runs-on: [single-gpu, nvidia-gpu, t4, past-ci] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the t4
? If we want to move to V100s or better we'll need to update again. As long as it's nvidia-gpu it should suffice, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can keep the t4
tag on the runner enrollment to identity which hardware it is running on and, in the future, if you end up having multiple flavours like we'll have for amd [mi210, mi250, mi300]
you can easily target them (or not).
See how we would like to approach it for AMD gpu flavours: https://github.com/huggingface/transformers/pull/26346/files#diff-0517e7d6ca0b03d887391fd62602e2891e13f279d32d464e3f73c6e864b8152fR48
Within the workflow I agree, at the moment, it might not bring any additional constraints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically no need t4
, it's there just to keep more info. explicitly.
Also is there a difference between the |
It's a typo for |
I see runners with the following tags on nvidia's side: |
The documentation is not available anymore as the PR was closed or merged. |
So far, each CI workflow is running in a dedicated runner by using tags/labels like Using explicit |
Talking to @glegendre01 we decide to keep these extra labels ( |
Yes, i'm not ready to deploy new runners on transformers now (focusing on 2 others topics). But will be able to handle it next week. at this moment we will remove extra labels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What does this PR do?
I also updated the labels on runners to have
t4
anddaily-ci
,push-ci
etc.