Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TextNet #34979

Merged
merged 161 commits into from
Jan 8, 2025
Merged

Add TextNet #34979

merged 161 commits into from
Jan 8, 2025

Conversation

jadechoghari
Copy link
Contributor

@jadechoghari jadechoghari commented Nov 27, 2024

What does this PR do?

This PR adds TextNet which will be used to add Fast.

It builds up on the work of this PR: #27425 (which was approved but not merged) and make it up to date with the library changes.

TODO:

  • Update the model's README file
  • Check why some tests are failing
  • Fix processing class errors
  • Fix modeling file errors

HF Model Cards:
TextNet-B: https://huggingface.co/jadechoghari/textnet-base
TextNet-S: https://huggingface.co/jadechoghari/textnet-small
TextNet-T: https://huggingface.co/jadechoghari/textnet-tiny

Notebook to replicate the author's logits:
https://colab.research.google.com/drive/1YsraOg-GHFh7PlvuIC9iJeBZquVWdz-r?usp=sharing

@jadechoghari jadechoghari requested a review from qubvel December 20, 2024 13:13
Copy link
Member

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just minor style fixes + the integration test should be fixed.

Is this the only one checkpoint https://huggingface.co/Raghavan/textnet-base? Would be also great to add a model card to it.

docs/source/en/model_doc/textnet.md Outdated Show resolved Hide resolved
src/transformers/models/textnet/configuration_textnet.py Outdated Show resolved Hide resolved
src/transformers/models/textnet/modeling_textnet.py Outdated Show resolved Hide resolved
src/transformers/models/textnet/modeling_textnet.py Outdated Show resolved Hide resolved
src/transformers/models/textnet/modeling_textnet.py Outdated Show resolved Hide resolved
src/transformers/models/textnet/modeling_textnet.py Outdated Show resolved Hide resolved
tests/models/textnet/test_modeling_textnet.py Outdated Show resolved Hide resolved
tests/models/textnet/test_modeling_textnet.py Outdated Show resolved Hide resolved
tests/models/textnet/test_modeling_textnet.py Outdated Show resolved Hide resolved
@jadechoghari
Copy link
Contributor Author

cc @qubvel 🚀

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the documentation is a bit lacking and we need to make sure the model is easy to use for the expected task: text detection!

Codewise lgtm!

docs/source/en/model_doc/textnet.md Show resolved Hide resolved
src/transformers/models/textnet/__init__.py Outdated Show resolved Hide resolved
src/transformers/models/textnet/configuration_textnet.py Outdated Show resolved Hide resolved
src/transformers/models/textnet/modeling_textnet.py Outdated Show resolved Hide resolved
src/transformers/models/textnet/modeling_textnet.py Outdated Show resolved Hide resolved
tests/models/textnet/test_modeling_textnet.py Show resolved Hide resolved
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating, LGTM! 🤗

@ArthurZucker ArthurZucker merged commit 7176e06 into huggingface:main Jan 8, 2025
23 checks passed
@ArthurZucker
Copy link
Collaborator

🥳

@jadechoghari
Copy link
Contributor Author

wohoo 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants