-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TextNet #34979
Add TextNet #34979
Conversation
got a confusion in `timm_wrapper` - was giving some conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just minor style fixes + the integration test should be fixed.
Is this the only one checkpoint https://huggingface.co/Raghavan/textnet-base? Would be also great to add a model card to it.
Co-authored-by: Pavel Iakubovskii <[email protected]>
Co-authored-by: Pavel Iakubovskii <[email protected]>
Co-authored-by: Pavel Iakubovskii <[email protected]>
Co-authored-by: Pavel Iakubovskii <[email protected]>
cc @qubvel 🚀 |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the documentation is a bit lacking and we need to make sure the model is easy to use for the expected task: text detection!
Codewise lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating, LGTM! 🤗
🥳 |
wohoo 🥳 |
What does this PR do?
This PR adds TextNet which will be used to add Fast.
It builds up on the work of this PR: #27425 (which was approved but not merged) and make it up to date with the library changes.
TODO:
HF Model Cards:
TextNet-B: https://huggingface.co/jadechoghari/textnet-base
TextNet-S: https://huggingface.co/jadechoghari/textnet-small
TextNet-T: https://huggingface.co/jadechoghari/textnet-tiny
Notebook to replicate the author's logits:
https://colab.research.google.com/drive/1YsraOg-GHFh7PlvuIC9iJeBZquVWdz-r?usp=sharing